Disable more deprecations. #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -363,15 +349,6 @@ def make_relative_symlink(src) | |||
| File.symlink(src.relative_path_from(dirname), self) | |||
| end | |||
|
|
|||
| unless method_defined?(:/) | |||
| def /(other) | |||
There was a problem hiding this comment.
Ruby 2.3.3 always defines this method.
| @@ -95,7 +95,6 @@ def parse | |||
| next if encoding.nil? | |||
|
|
|||
| # use the specified encoding for the rest of the file | |||
| next unless String.method_defined?(:force_encoding) | |||
There was a problem hiding this comment.
Don't change vendored code.
Library/Homebrew/extend/fileutils.rb
Outdated
| # @private | ||
| alias old_ruby ruby | ||
| end | ||
|
|
||
| # Run the `ruby` Homebrew is using rather than whatever is in the `PATH`. | ||
| def ruby(*args) |
There was a problem hiding this comment.
Seems like this isn't used anywhere. Should we deprecate this?
4 tasks
- Turn more old `odeprecated` into `odisabled` - Remove more old `odisabled` - Remove code for older Ruby versions
These don't need to live on FileUtils and don't really make sense there either.
5 tasks
jonchang
added a commit
to brewsci/homebrew-science
that referenced
this pull request
Jul 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odeprecatedintoodisabledodisabledThis should not be merged until we are sure the next version will be 1.7.0.
CC cask folks for the @Homebrew/cask changes.
brew stylewith your changes locally?brew testswith your changes locally?