test_integration_cmds: compile in install test. #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,6 +123,10 @@ def setup_test_formula(name, content = nil) | |||
| def install | |||
| (prefix/"foo"/"test").write("test") if build.with? "foo" | |||
| prefix.install Dir["*"] | |||
| (buildpath/"test.c").write \ | |||
| "#include <stdio.h>\\nint main(){printf(\\"test\\");}" | |||
There was a problem hiding this comment.
I was so hoping for the first nested heredoc. 😉
But in all seriousness, you might want to add a return 0; to that main function, as some older versions of Clang tend to produce code that generates a random exit code otherwise. (Which will be annoying if we decide to use this formula/binary to test brew test.)
|
Interesting that adding this line afterwards doesn't move the PR into the list of notifications one is participating in (in the GitHub web UI). |
Most of our formulae do compilation so let's do it here too.
souvik1997
pushed a commit
to souvik1997/brew
that referenced
this pull request
Jul 25, 2016
Most of our formulae do compilation so let's do it here too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Most of our formulae do compilation so let's do it here too.
CC @UniqMartin @eirinikos