Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/args: Make build_from_source public instance method #7333

Merged
merged 3 commits into from
Apr 19, 2020
Merged

cli/args: Make build_from_source public instance method #7333

merged 3 commits into from
Apr 19, 2020

Conversation

GauthamGoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#5730

@GauthamGoli
Copy link
Contributor Author

@MikeMcQuaid Some tests are failing whenever install_test_formula is being called. One way to fix them is by adding a nil check on cmdline_args whenever its being used in cli/args.rb but I don't think thats the right way, instead, may be have a generic way of initiating args in tests.

Need your input on how to solve this.

MikeMcQuaid
MikeMcQuaid approved these changes Apr 12, 2020
View reviewed changes
Library/Homebrew/cli/parser.rb Show resolved Hide resolved
@MikeMcQuaid
cli/args: simplify initialisation.
8d868b7 
Move some logic from `CLI::Parser` to `CLI::Args` to simplify and make
more consistent the initialisation process.
@GauthamGoli
Copy link
Contributor Author

This is a cleaner approach. Thanks for the help @MikeMcQuaid

@MikeMcQuaid
Copy link
Member

You're welcome @GauthamGoli, thanks for the PR!

@MikeMcQuaid MikeMcQuaid merged commit 2bbcab5 into Homebrew:master Apr 19, 2020
@d12frosted d12frosted mentioned this pull request Apr 20, 2020
Closed
3 tasks
@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauthamGoli @MikeMcQuaid