Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmp: add arm64 compatibility patch #288

Merged
merged 1 commit into from
Jul 6, 2020
Merged

gmp: add arm64 compatibility patch #288

merged 1 commit into from
Jul 6, 2020

Conversation

claui
Copy link
Contributor

@claui claui commented Jul 4, 2020

This commit consolidates the two patches proposed in Homebrew/homebrew-core#57315.

@claui
gmp: add arm64 compatibility patch
6f75ed4 
This commit consolidates the two patches proposed in
Homebrew/homebrew-core#57315.

Suggested-by: FX Coudert <fxcoudert@gmail.com>
@claui claui requested a review from fxcoudert July 4, 2020 12:14
@claui claui mentioned this pull request Jul 4, 2020
Merged
5 tasks
@claui claui requested a review from a team July 5, 2020 10:57
@claui
Copy link
Contributor Author

claui commented Jul 5, 2020 •
edited
Loading

Pinging @Homebrew/core for review, as this is blocking Homebrew/homebrew-core#57315.

I already double-checked that this consolidated patch works on arm64.

SMillerDev
SMillerDev approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a patch to me

MikeMcQuaid
MikeMcQuaid approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as long as these have been submitted upstream.

@claui
Copy link
Contributor Author

claui commented Jul 6, 2020 •
edited
Loading

@MikeMcQuaid Sort of; we just owe them feedback on the latest update of this patch.

Update: done and acknowledged.

@claui claui closed this Jul 6, 2020
@claui claui reopened this Jul 6, 2020
@claui claui merged commit c53834b into Homebrew:master Jul 6, 2020
@claui claui deleted the gmp-arm branch July 6, 2020 12:41
@claui
Copy link
Contributor Author

claui commented Jul 6, 2020

Thanks @SMillerDev and @MikeMcQuaid for your feedback!

@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

@fxcoudert fxcoudert Awaiting requested review from fxcoudert

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@claui @MikeMcQuaid @SMillerDev @BrewTestBot