-
-
Notifications
You must be signed in to change notification settings - Fork 463
Conversation
Created a cask for all variants. |
Holy crap. Are you telling me there are 3200 variants? That is insane. They all need a For context on how insane 3000 files for a single font is, we have under 1000 font casks, and only 2651 casks in the main repo. Pinging @ndr-qef since you’ve been dealing with this repo more. I’d also like to know if @jawshooah and @victorpopkov have an opinion on the matter. I say we can’t accept this, and the best course of action is for someone to provide and maintain a tap. I don’t even find it easy to believe anyone who would want to install this via homebrew-cask would go through the trouble of understanding exactly what cask they need. In case you’re wondering how they manage all this for people who want to download them, they provide a way to select what you want on the website, prior to downloading. |
This is truly insane to merge this in my opinion. @sscotth, we all really do appreciate all the hard work you have done to prepare this PR. You are awesome! But for I fully agree with @vitorgalvao, probably the best option would be to make a separate tap for this, but I can't imagine who will be able to maintain this all the time. I don't say that this is impossible, and most likely the original repository for Monoid font won't change very often when it becomes more stable. However, having a separate tap only for that also seems like a bizarre idea. It simply wasn't designed to deal with this kind of situations. But, nevertheless, this PR is surely epic. |
Agreed with @vitorgalvao and @victorpopkov; it just isn't reasonable to maintain this many files for a single font. The best solution in my view would be to select one version as the "default" and include it here. If someone else, perhaps @sscotth, feels inclined to create and maintain a custom tap with the thousands of other variants, they are free to do so. |
Seems like we have some consensus. I’d even be OK with including in the cask a
That way whoever installs the font also knows where to look for other styles. What do you think, @sscotth? If you need help creating a tap we can help. It isn’t hard. Either way, I’d like to thank you once more for the work you’ve put here. |
It wasn't bad, wrote a simple node script to generate the casks. I figured with all the variants of Noto that it wan't a big deal. Adding the Github comment is no problem, I just noticed many fonts that didn't have such a mention. https://github.com/caskroom/homebrew-fonts/blob/master/Casks/font-abeezee.rb Should I just add the tap comment above as a comment in the cask? |
That’s bad, and we need to fix those. Keep in mind that is only necessary when the host of
Not a comment, but a caveat (example), so something like caveats <<-EOS.undent
#{token} only installs the Normal weight with medium line height.
To get other styles, please tap the <whatever> repo
brew tap <whatever>
EOS This ensures people will be informed when |
@sscotth @vitorgalvao @larsenwork Thank you all for the effort! |
Not sure how best to handle all the variants: https://github.com/larsenwork/monoid/tree/release