Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate name stanza into brew cask search #17323

Closed
jawshooah opened this issue Jan 19, 2016 · 5 comments
Closed

Incorporate name stanza into brew cask search #17323

jawshooah opened this issue Jan 19, 2016 · 5 comments

Comments

@jawshooah
Copy link
Contributor

I didn't realize we hadn't implemented this yet, since I could find no open issues documenting our intention to do so.

Note: this was previously brought up in #13952, and likely in earlier discussions as well.

@jawshooah jawshooah added enhancement core Issue with Homebrew itself rather than with a specific cask. labels Jan 19, 2016
@alexchandel
Copy link
Contributor

Please yes. You would expect brew cask search quicklook to find everything that mentions QuickLook, and yet it misses qlvideo even though it has name 'QuickLook Video'.

@claui
Copy link
Contributor

claui commented Jun 16, 2016

I have implemented it a while ago to get familiar with the core.

It just needs a rebase, a few tests, and a thorough review (in that order).

@gentlecat
Copy link
Contributor

I've been looking into this today and got something basic working: Homebrew/brew@master...gentlecat:name-search. Am I going in the right direction with this or should it be implemented differently? I'm very much new to the codebase (and the language), so I won't be surprised if something is completely wrong. :)

I'm also not quite sure what would be the best way to display results of the name search. I imagine it would be useful to show both name and token of a cask, and whether it's already installed. But I don't yet know how to modify Formatter cleanly to do this.

@claui
Copy link
Contributor

claui commented Oct 23, 2017

@gentlecat I’m happy to see someone taking care of this task, and appreciate that a lot!

As I’ll be extra busy this week, I’d appreciate other maintainers to take a look at your work (and at your question). If no one does, I’ll get back to you by the end of the week, hopefully.

@commitay
Copy link
Contributor

brew cask search has been replaced by brew search. Casks can be searched by name using brew search --desc.

$ brew search --desc jetbrains
==> Formulae

==> Casks
jetbrains-toolbox: JetBrains Toolbox
pycharm-edu: Jetbrains PyCharm Educational Edition, PyCharm Edu
phpstorm: JetBrains PhpStorm
rider: Jetbrains Rider
youtrack-workflow: JetBrains Youtrack Workflow Editor
mps: JetBrains MPS
pycharm-ce: Jetbrains PyCharm Community Edition, PyCharm CE

@commitay commitay removed core Issue with Homebrew itself rather than with a specific cask. enhancement ready to implement labels Jul 20, 2018
@lock lock bot locked and limited conversation to collaborators Aug 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants