Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudApp v4.2.1 #32674

Closed

Conversation

malthejorgensen
Copy link

@malthejorgensen malthejorgensen commented Apr 20, 2017

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@malthejorgensen
Copy link
Author

When you download from https://www.getcloudapp.com you get version 4.2.1.
However, as soon as you install you're prompted to update to 4.2.2 – even so, because it's the officially downloadable version I believe this belongs in stable.

@miccal
Copy link
Member

miccal commented Apr 20, 2017

Already available.

@miccal miccal closed this Apr 20, 2017
@malthejorgensen
Copy link
Author

Sorry about that. It's cause I did brew cask search cloudapp and got nothing – we should probably have an alias or rename the recipe to cloudapp? 🙃

@vitorgalvao
Copy link
Member

we should probably have an alias or rename the recipe to cloudapp?

No. Token reference.

@malthejorgensen
Copy link
Author

malthejorgensen commented Apr 20, 2017 via email

@vitorgalvao
Copy link
Member

vitorgalvao commented Apr 20, 2017

You misunderstand – the name of the product (and the company) is literally CloudApp – not Cloud.

Yes, I know. I’m familiar with the app.

I don't think the intention of that part of the Token reference

I wrote most of the token reference, and the parts I didn’t write had my input. I’m pretty sure I know its intentions. This app in particular was much discussed at the time.

However, having said that, I do concede this one has already caused an inordinate amount of confusion, so lets indeed rename it.

@malthejorgensen
Copy link
Author

Sorry for being a bit stubborn – just trying to make it easier for the next "homebrewer" stumbling on the same problem 😊 Would it make sense to expand the brew cask search to also search the name of the recipe? (I would be happy to make a PR)

Thank you @vitorgalvao!

@malthejorgensen
Copy link
Author

malthejorgensen commented Apr 21, 2017

Ok, I can see that there's already some work done on that (#17323) – ignore the above.

Once again – thank you for the great work! 👍

@vitorgalvao
Copy link
Member

Would it make sense to expand the brew cask search to also search the name of the recipe? (I would be happy to make a PR)

It’s an actively desirable feature. Please do!

Ok, I can see that there's already some work done on that (#17323)

That work is from 2014. Much/most of it is no longer applicable with the current codebase. Feel free to work on it.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants