-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CloudApp v4.2.1 #32674
Add CloudApp v4.2.1 #32674
Conversation
When you download from https://www.getcloudapp.com you get version 4.2.1. |
Sorry about that. It's cause I did |
No. Token reference. |
You misunderstand – the name of the product (and the company) is literally
CloudApp – not Cloud. I don't think the intention of that part of the Token
reference is to remove App from CloudApp (or WhatsApp for that matter), but
rather remove app from generic names like "Wireless Transfer App.app" or
superfluous usage like "PomoDoneApp.app"
…On Thu, Apr 20, 2017 at 2:37 PM, Vítor Galvão ***@***.***> wrote:
we should probably have an alias or rename the recipe to cloudapp?
No. Token reference
<https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/token_reference.md>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32674 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAllYPqaVQopqcCF1zaCsFv9j3L5SMe_ks5rx1FzgaJpZM4NC6bX>
.
|
Yes, I know. I’m familiar with the app.
I wrote most of the token reference, and the parts I didn’t write had my input. I’m pretty sure I know its intentions. This app in particular was much discussed at the time. However, having said that, I do concede this one has already caused an inordinate amount of confusion, so lets indeed rename it. |
Sorry for being a bit stubborn – just trying to make it easier for the next "homebrewer" stumbling on the same problem 😊 Would it make sense to expand the Thank you @vitorgalvao! |
Ok, I can see that there's already some work done on that (#17323) – ignore the above. Once again – thank you for the great work! 👍 |
It’s an actively desirable feature. Please do!
That work is from 2014. Much/most of it is no longer applicable with the current codebase. Feel free to work on it. |
If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}
worked successfully.brew cask uninstall {{cask_file}}
worked successfully.