Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Accessibility Access override for OSX 10.12 #24519

Closed
vitorgalvao opened this issue Sep 15, 2016 · 6 comments
Closed

Disable Accessibility Access override for OSX 10.12 #24519

vitorgalvao opened this issue Sep 15, 2016 · 6 comments

Comments

@vitorgalvao
Copy link
Member

Duplicate of Homebrew/brew#905.

TCC.db is (rightfully) protected by SIP in Sierra.

We should prevent enable_accessibility_access if MacOS.release >= :sierra (throw up a caveat instead?)

Moving it here since we have other core bugs here.

@reitermarkus @jawshooah What’s your take on issues related to HBC? Here or on HB’s repo?

@vitorgalvao vitorgalvao added bug Issue describing a reproducible bug. awaiting maintainer feedback Issue needs response from a maintainer. core Issue with Homebrew itself rather than with a specific cask. labels Sep 15, 2016
@adidalal
Copy link
Contributor

Not sure where it goes but if no one picks it up, I can probably add in the conditional this weekend. (Interestingly, I think fixing accessibility for 10.11 was my very first core HBC contribution)

@reitermarkus
Copy link
Member

reitermarkus commented Sep 16, 2016

What’s your take on issues related to HBC? Here or on HB’s repo?

For now, I'd leave them here as there are still quite a few open, and when they are down to a smaller number, migrate them to Homebrew.

Also, we could add minor issues which are low priority but can be fixed relatively easily to the newly introduced Projects tab.

@vitorgalvao
Copy link
Member Author

Also, we could add minor issues which are low priority but can be fixed relatively easily to the newly introduced Projects tab.

Was also thinking of adding issues with ready to implement, there. And perhaps even cask requests and documentation requirements.

Something to close #17337, basically. Something we can point users to help where they can pick what to help with depending on their level of expertise.

@wickles
Copy link
Contributor

wickles commented Sep 19, 2016

Which component of SIP needs to be disabled for this to work? Should TCC.db access be disabled entirely for macOS >= Sierra, or should it check the SIP config first and handle appropriately? (Also note disable_accessibility_access should be prevented as well.)

@vitorgalvao
Copy link
Member Author

Disabling SIP is not something we should either be trying to do or encourage users to do.

wickles pushed a commit to wickles/brew that referenced this issue Sep 19, 2016
See Homebrew/homebrew-cask#24519

Feel free to suggest alternative wording and such.
@vitorgalvao
Copy link
Member Author

Closing in favour of Homebrew/brew#1029.

@miccal miccal removed the awaiting maintainer feedback Issue needs response from a maintainer. label Dec 15, 2016
@miccal miccal removed bug Issue describing a reproducible bug. core Issue with Homebrew itself rather than with a specific cask. labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants