Checking for GDAL Framework Dependency

[hanxue]

I am trying to create a new cask qgis hanxue@53d9acf

1. Why does homebrew cask allow the installation to be marked as successful when the Installer returns an error?

$ brew cask install ./qgis.rb 
==> Downloading http://www.kyngchaos.com/files/software/qgis/QGIS-2.2.0-10.dmg
Already downloaded: /Library/Caches/Homebrew/qgis-2.2.0-10.dmg
==> Running installer for qgis; your password may be necessary.
Password:
==> installer: Error - The GDAL 1.11 framework is required.
🍺  qgis installed to '/opt/homebrew-cask/Caskroom/qgis/2.2.0-10' (6 files, 159M)

As a result, QGIS Installer.pkg get's copied over to the caskroom. If I execute it manually I see this message.

GDAL Framework is actually installed

$ brew info gdal
gdal: stable 1.11.0 (bottled), HEAD
http://www.gdal.org/
/usr/local/Cellar/gdal/1.11.0 (228 files, 33M) *
  Poured from bottle
From: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/gdal.rb

1. How can I tell the installer to look for the framework?

[rolandwalker]

Interesting. Thanks for working on this.

If the Apple program installer does not exit with an error code, we don't call it a failure. Instead we keep on with the installation. So the first step would be to run the install command with --debug so that we can see what is going on, then run the installer command by hand and see if it exits with an error.

Telling QGIS Installer.pkg how to find the GDAL framework that brew previously installed is sort of a separate question. I would start by opening up the pkg file and looking at the preflight scripts

$ pkgutil --expand  './QGIS Installer.pkg' QGIS_Installer_unpacked

I'll try to help you with it a little later.

Incidentally, this Cask can use

  depends_on_formula 'gdal'

to get Homebrew to install the dependency automatically. Though as we have seen, the pkg installer doesn't like that location very much.

[rolandwalker]

See the file Distribution inside the unpacked pkg for the install requirements. The file /Library/Frameworks/GDAL.framework/Versions/1.11/Resources/Info.plist must exist, among others.

[hanxue]

Indeed, it depends on GDAL framework. Here's the (brew cask install --debug)[https://gist.github.com/hanxue/b454a201a6c53745acf3#file-brew-cask-install-debug-log] output
(Distribution)[https://gist.github.com/hanxue/b454a201a6c53745acf3#file-qdal-framework-distribution-xml]
QGIS PackageInfo - https://gist.github.com/hanxue/b454a201a6c53745acf3#file-qgis-packageinfo-xml

I am going to install GDAL from http://www.kyngchaos.com/software/frameworks instead, and will update the results.

[hanxue]

How can I create a dependency on a Cask (not a homebrew formula)?

[vitorgalvao]

You can’t, yet.

[rolandwalker]

For the moment, most such cases just print a caveat explaining how to install the dependency.

[hanxue]

Thank you for the advice. Updated the QGIS Cask with caveat.

I think it is preferable to have QGIS depend on GDAL and matplotlib that is installed by Homebrew, instead of having to install these frameworks separately. Can I get anyone's help to make QGIS work with homebrew formulas, instead of separately installed frameworks?

[rolandwalker]

From my first look at the package, I also didn't understand how to make it work with Homebrew Formulae.

[hanxue]

I guess we keep it simple and install the Framework dependencies as separate Casks. Could someone kindly take a look at the pull request #5095 ?

[rolandwalker]

#5095 looks good, merged.

[tapeinosyne]

Cask dependencies have been introduced in brew-cask version 0.52.