Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall stanzas to improve #6222

Closed
24 of 35 tasks
rolandwalker opened this issue Sep 17, 2014 · 4 comments
Closed
24 of 35 tasks

uninstall stanzas to improve #6222

rolandwalker opened this issue Sep 17, 2014 · 4 comments

Comments

@rolandwalker
Copy link
Contributor

currently uses uninstall :delete

These would clearly be improved by using uninstall :pkgutil. If possible, the :delete directive should be removed.

currently lacks uninstall :delete or uninstall :script

This occurred because a :delete directive was moved to the zap stanza in #6164.

currently uses uninstall :script

uninstall :script is fine and does not need to change. However, these Casks would still be improved by adding a :pkgutil directive. The :pkgutil directive would help robustness in corner cases, such as when the installation has been mangled and the expected uninstall script is missing.

References

#3322

@tapeinosyne
Copy link
Contributor

I took the liberty of updating the opening message with information concerning the uninstall stanza of specific entries.

The Netbeans IDEs appear to share a common ID, org.netbeans.ide.baseide.#{version}, which should likely not be removed by our uninstall.

Tangential: growl-fork seems to be an unofficial build, which we should move to caskroom/unofficial.

@rolandwalker
Copy link
Contributor Author

ntfs-free.rb may appear to have no bundle ID because it uses Apple bundle IDs which are filtered out by the development scripts. Nonetheless we shouldn't uninstall those IDs.

@vitorgalvao
Copy link
Member

cartao-de-cidadao is a tricky one. I was the one to add it. It’s software to work together with a hardware device to interact with Portuguese (and perhaps other similar) ID cards. Trying to get everything correct for the uninstall was a mess, so it was great when I found out they had packaged a script. Not to say it can’t be done, naturally, but it does have some weirdnesses, like the aforementioned nonspecific ID.

@vitorgalvao
Copy link
Member

Most of these are not needed or terribly outdated, :pkgutil isn’t perfect anyway so it shouldn’t be the standard for correctness, and others simply can’t be solved with it.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants