Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casks which lack uninstall stanza #3322

Closed
36 tasks done
rolandwalker opened this issue Mar 1, 2014 · 12 comments
Closed
36 tasks done

Casks which lack uninstall stanza #3322

rolandwalker opened this issue Mar 1, 2014 · 12 comments
Assignees

Comments

@rolandwalker
Copy link
Contributor

Following up on #2151, here is a list of remaining pkg-based Casks which use install but not uninstall.

From the end-user's point-of-view, this means that brew cask uninstall does not work as expected. Furthermore, it is a silent failure.

@alebcay
Copy link
Member

alebcay commented Mar 4, 2014

the-archive-browser.rb uses link and does not install any packages.

@rolandwalker
Copy link
Contributor Author

thanks. one more down!

@kevinSuttle
Copy link

Truth. Let's add xScope, shortcat, path-finder, reflector, sourcetree, webstorm, xscope_, openemu_,
screenshot 2014-03-15 14 30 34

OpenEmu and xScope actually have errors:
screenshot 2014-03-15 14 35 44

@alebcay
Copy link
Member

alebcay commented Mar 15, 2014

On a lighter note, what themes/styling are you using on your Terminal and how'd you get a screenshot like that?

@nanoxd
Copy link
Contributor

nanoxd commented Mar 15, 2014

@kevinSuttle
Copy link

Yep, @sindresorhus' pure-zsh theme. I just used the standard CMD-SHIFT-4 and drag the screenshot into the comment area.
Font is Fira Mono 16pt
Color scheme is Dracula for iTerm

Aside, I'm noticing that my uninstall stanza for xmarks-safari works, but says that it doesn't.

❯ brew cask uninstall xmarks-safari
==> Running uninstall process for xmarks-safari; your password may be necessary
==> sudo: /opt/homebrew-cask/Caskroom/xmarks-safari/2.0.13/Uninstall Xmarks.app: command not found

The cask is removed from my system, but that error makes me thing I'm doing it wrong.

"/usr/local/Library/Taps/phinze-cask/Casks/xmarks-safari.rb" 9L, 336C
class XmarksSafari < Cask
    url 'https://static.xmarks.com/clients/safari/xmarks_for_safari_2.0.13.dmg'
    homepage 'http://www.xmarks.com/'
    version '2.0.13'
    sha1 '7c50605de34b27b426f24b2ff264654aaa3d5175'
    install 'Xmarks for Safari Installer.pkg'
    uninstall :script => { :executable => 'Uninstall Xmarks.app', :input => %w[Yes] }
end

@sigito
Copy link
Contributor

sigito commented Mar 18, 2014

Same issue with send-to-kindle.rb as @kevinSuttle has. This app shipped with uninstaller /Applications/Send to Kindle/Uninstall Send to Kindle.app, but unfortunately I cannot find way to call it from uninstall stanza.
For screens-connect.rt/opt/homebrew-cask/Caskroom/screens-connect/latest/Uninstall Screens Connect.app

@rolandwalker
Copy link
Contributor Author

Yes, an .app bundle is intended for user interaction via the GUI -- it is not a CLI executable, though one or more Mach-O executables are inside a bundle.

Sometimes a shell script or decompilable AppleScript is inside an app bundle, and we can adapt that for the uninstaller. For send-to-kindle.rb that should not be needed -- we ought to be able to use a :pkgutil directive.

@alebcay
Copy link
Member

alebcay commented Jun 12, 2014

I'd say I've gone as far as I can for now. zooom has upstream-based installation issues per #4802, obsidian-menu-bar is in a similar state per #2750, and somebody else will probably need to take a look at paragon-ntfs and paragon-extfs, as they're a bit too complex for me to figure out (too much stuff happening in those).

@rolandwalker
Copy link
Contributor Author

@alebcay you did great work here, much appreciated by me.

obsidian-menu-bar is a beast; I don't know if ever installed reliably.

If I can work out something for the paragon Casks, and then maybe hack the others to be caskroom_only, we can institute an audit test requiring that install have a matching uninstall.

@alebcay
Copy link
Member

alebcay commented Jul 16, 2014

Just a follow up on obsidian-menu-bar: I installed a Cask and took a look at the package contents - looked like about 10 or so different package IDs. After placing them all in an uninstall script and executing it, I couldn't open any new windows (they would all crash). I ended up going to the manufacturer website and downloading the uninstall stuff to manually uninstall the packages.

Perhaps in a future Cask release, consider adding uninstall :pkg that installs a pkg during uninstallation - I've seen a couple of other Casks that use this type of uninstallation. Perhaps a less ambiguous name as uninstall :pkg should be chosen.

@vitorgalvao
Copy link
Member

I’ve gotten the paragon uninstalls working, but there’s a small caveat (second paragraph). They share a :launchctl ID, so I’m not sure what we should do with it. I’m for including it in the cask (meaning it should be removed from the system), but I can certainly see sense in the opposite point.

@miccal miccal removed the roadmap label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants