Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmoothMouse #2204

Closed
niksy opened this issue Dec 24, 2013 · 6 comments
Closed

Add SmoothMouse #2204

niksy opened this issue Dec 24, 2013 · 6 comments

Comments

@niksy
Copy link
Contributor

niksy commented Dec 24, 2013

It’s my first attempt in creating a Cask, so I would like if someone could review this and see if it’s feasible to have this in repository. I can create pull request if everything is OK.

This is the Cask for excellent "preference pane" called SmoothMouse which greatly improves OSX mouse acceleration and handling (depends on who you ask), making it possible to have acceleration similar to those available in Windows and Linux OS’.

class Smoothmouse < Cask
  url 'http://smoothmouse.com/download/latest/'
  homepage 'http://smoothmouse.com/'
  version 'latest'
  no_checksum
  install 'SmoothMouse.pkg'
  uninstall :script => '/Library/PreferencePanes/SmoothMouse.prefPane/Contents/Resources/uninstall.sh'
end

What I’m interested in is:

  • Is checksum needed since we’re always looking for latest version?
  • Preference pane has button for uninstall which obviously calls uninstall.sh script but I’m not sure if by calling it it sends some additional parameters. By looking at it, it simply removes kernel extensions and optionally passes parameter for keeping preferences (not sure where this is defined), but other than that, it seems straightforward.
@fanquake
Copy link
Contributor

@niksy If your using

version 'latest'

then no, a checksum is not needed.

As for the uninstall script, I'm pretty sure that should be ok? @phinze @nanoxd

Open up a pull request!

@niksy
Copy link
Contributor Author

niksy commented Dec 24, 2013

Just checked this in little more detail.

  • Uninstall script gets its "keep preferences" parameter via checkbox when you click on "Uninstall" button. It’s disabled by default. Is there an option where users can decide if they want to have their preferences kept or deleted?
  • When activating installation package, there is an alert window warning users about some incompatibilities when using LCC or similar tools (see screenshot). That message is shown inside terminal and installation seems to go well, but I didn’t get any option where I can choose to abort installation or continue. Is this normal?

@henrikbjorn
Copy link

Seems like this can be closed? It already exists?

@rolandwalker
Copy link
Contributor

Yes, it can -- thanks for finding that!

@vitorgalvao
Copy link
Member

The present cask is missing uninstall, which is discussed in this issue. Does anyone want to tackle that?

rolandwalker added a commit to rolandwalker/homebrew-cask that referenced this issue Apr 1, 2014
per Homebrew#2204.  Note: in testing, this uninstall is
imperfect, but should be complete after the next reboot.
@rolandwalker
Copy link
Contributor

Good point, @vitorgalvao. I sent a PR. I'm tracking all such cases in #3322 as well.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants