Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

league_of_legends.rb uses both app and caveats ... manual_installer #6870

Closed
rolandwalker opened this issue Oct 21, 2014 · 0 comments · Fixed by #6902
Closed

league_of_legends.rb uses both app and caveats ... manual_installer #6870

rolandwalker opened this issue Oct 21, 2014 · 0 comments · Fixed by #6902

Comments

@rolandwalker
Copy link
Contributor

It should be only one or the other:

https://github.com/caskroom/homebrew-cask/blob/c093d9df6abb1ebae4c999c56521142668665eba/Casks/league-of-legends.rb#L9
@rolandwalker rolandwalker mentioned this issue Oct 21, 2014
Closed
8 tasks
rolandwalker added a commit to rolandwalker/homebrew-cask that referenced this issue Oct 22, 2014
@rolandwalker
remove manual_installer from league_of_legends
35187ea 
From what I can tell by reading, this is an ordinary `app`
artifact.  It cannot be both `app` and `installer :manual`.

closes Homebrew#6870
@rolandwalker rolandwalker mentioned this issue Oct 22, 2014
Merged
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove manual_installer from league_of_legends rolandwalker/homebrew-cask
1 participant
@rolandwalker