Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Hbc::Staged module in Hbc::DSL::Preflight #13612

Merged
merged 1 commit into from
Sep 5, 2015
Merged

Include Hbc::Staged module in Hbc::DSL::Preflight #13612

merged 1 commit into from
Sep 5, 2015

Conversation

jawshooah
Copy link
Contributor

This will provide the preflight block with the set_permissions and set_ownership helpers, among others. The preflight block is executed after cask files have been staged, so there's no reason not to include this module.

Refs #13607

Review on Reviewable

@jawshooah jawshooah added enhancement awaiting maintainer feedback Issue needs response from a maintainer. core Issue with Homebrew itself rather than with a specific cask. labels Sep 5, 2015
@vitorgalvao
Copy link
Member

Feel free to merge at will.

@jawshooah jawshooah changed the title Include Hbc::Staged module in Hbc::DSL::Preflight Include Hbc::Staged module in Hbc::DSL::Preflight Sep 5, 2015
jawshooah added a commit that referenced this pull request Sep 5, 2015
Include `Hbc::Staged` module in `Hbc::DSL::Preflight`
@jawshooah jawshooah merged commit 7013f49 into Homebrew:master Sep 5, 2015
@jawshooah jawshooah deleted the preflight-include-staged branch September 5, 2015 18:01
@adidalal adidalal removed the awaiting maintainer feedback Issue needs response from a maintainer. label Jan 3, 2016
@miccal miccal removed core Issue with Homebrew itself rather than with a specific cask. enhancement labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants