Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YouTube Music v1.20.0 #148404

Closed
wants to merge 1 commit into from

Conversation

mehdichaouch
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask youtube-music worked successfully.
  • brew install --cask youtube-music worked successfully.
  • brew uninstall --cask youtube-music worked successfully.

@@ -0,0 +1,38 @@
cask "youtube-music" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unofficial client, should it be renamed to youtube-music-th-ch ? What happens if YouTube Music makes a native app in the future?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be renamed, although there is another unnofficial client called yt-music.

@razvanazamfirei razvanazamfirei added the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label Jul 4, 2023
@BrewTestBot BrewTestBot removed the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label Jul 4, 2023
@mehdichaouch
Copy link
Author

@razvanazamfirei can I get some help on how to make this contribution valid.

Thank you

@razvanazamfirei
Copy link
Contributor

Hi @mehdichaouch, we cannot accept it at this time because it does not pass our signature verification check that are a requirement for new submissions:

macOS on ARM requires applications to be signed. Please contact the upstream developer to let them know they should notarize their package.

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Aug 5, 2023
@github-actions github-actions bot closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new cask stale Issue which has not received any feedback for some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants