Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch mactex download link #15196

Closed
wants to merge 1 commit into from
Closed

Switch mactex download link #15196

wants to merge 1 commit into from

Conversation

adidalal
Copy link
Contributor

This link automatically redirects users to the best download location, but we lose "versioning" as the URL does not have a #{version}

The package is huge, so arguably download speed is important

Based on a comment in the Gitter chat by @fanquake

@adidalal
Copy link
Contributor Author

Merged as b280b4e.

@adidalal adidalal closed this Nov 15, 2015
@adidalal adidalal deleted the update-mactex branch November 15, 2015 21:43
@vitorgalvao
Copy link
Member

Download speed is important, yes, but so are versions, and those are arguably more important. Isn’t there a way to get the best of both worlds?

Example of a case where this change caused issues.

@adidalal
Copy link
Contributor Author

Unfortunately, it looks like the round-robin redirect doesn't have any version in its URL.

We could "fix" this by going back to having an explicit version and shasum (and keeping the unversioned URL), but this will cause an ungraceful fail when the package is updated. Not sure if that's any better, but it's an option.

@vitorgalvao vitorgalvao mentioned this pull request Dec 8, 2015
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants