-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 360Controller driver v0.14 #15208
Conversation
Same as d235j-xbox360-controller-driver Cask but repository name changed
The current cask needs to be changed. Not add a new one. |
Thank you for the contribution, but it’ll be fixed shortly in a different PR. |
@vitorgalvao the existing cask name no longer reflects the project name, which makes it confusing for newcomers. |
And that’s exactly why the cask was renamed. Keeping it with the old name to something that doesn’t exist makes no sense. |
@vitorgalvao I think whats being asked is a rename from |
and @vin047, we use homebrew-cask for stable versions, but feel free to submit a PR for "v0.15_beta3_unofficial" to homebrew-versions if you are so inclined. |
@adityadalal924 Not exactly. @vin047 was adding a cask that is just an existing one with a new repo, and leaving the existing one without changes (dead). Either way, the matter is fixed. I’m also a user of the driver ever since the original (from Tattiebogle), and it makes sense to have it like this. |
Ah I see. To me, the rename makes sense (ie. using the github project name as the canonical cask name), but as I don't use the cask, it doesn't make too much of a difference to me. |
@vitorgalvao apologies, I didn't realise you had already consolidated the existing casks. Makes sense now, thanks. |
No worries.
Since we don’t have clear rules for |
Same as d235j-xbox360-controller-driver Cask but repository name changed