Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 360Controller driver v0.14 #15208

Closed
wants to merge 1 commit into from
Closed

Add 360Controller driver v0.14 #15208

wants to merge 1 commit into from

Conversation

vin047
Copy link
Contributor

@vin047 vin047 commented Nov 16, 2015

Same as d235j-xbox360-controller-driver Cask but repository name changed

Same as d235j-xbox360-controller-driver Cask but repository name changed
@vitorgalvao
Copy link
Member

The current cask needs to be changed. Not add a new one.

@vitorgalvao
Copy link
Member

Thank you for the contribution, but it’ll be fixed shortly in a different PR.

@vin047
Copy link
Contributor Author

vin047 commented Nov 16, 2015

@vitorgalvao the existing cask name no longer reflects the project name, which makes it confusing for newcomers.

@vitorgalvao
Copy link
Member

And that’s exactly why the cask was renamed. Keeping it with the old name to something that doesn’t exist makes no sense.

@adidalal
Copy link
Contributor

@vitorgalvao I think whats being asked is a rename from xbox360-controller-driver to 360Controller, which seems to make sense given that the project itself has changed names (rather, it looks like the old project was discontinued, and this is the most active current fork)

@adidalal
Copy link
Contributor

and @vin047, we use homebrew-cask for stable versions, but feel free to submit a PR for "v0.15_beta3_unofficial" to homebrew-versions if you are so inclined.

@vitorgalvao
Copy link
Member

@adityadalal924 Not exactly. @vin047 was adding a cask that is just an existing one with a new repo, and leaving the existing one without changes (dead).

Either way, the matter is fixed. I’m also a user of the driver ever since the original (from Tattiebogle), and it makes sense to have it like this.

@adidalal
Copy link
Contributor

Ah I see. To me, the rename makes sense (ie. using the github project name as the canonical cask name), but as I don't use the cask, it doesn't make too much of a difference to me.

@vin047
Copy link
Contributor Author

vin047 commented Nov 16, 2015

@vitorgalvao apologies, I didn't realise you had already consolidated the existing casks. Makes sense now, thanks.

@vitorgalvao
Copy link
Member

apologies, I didn't realise you had already consolidated the existing casks.

No worries.

To me, the rename makes sense (ie. using the github project name as the canonical cask name)

Since we don’t have clear rules for pkg casks, I kept it like this for consistency, but also as a bit of proactivity with possible renames. If/when #14384 goes through, we might or might not lose the ability of starting cask names with numbers, so since this one makes sense with a name before, this way we ensure it won’t need to change.

@vin047 vin047 deleted the xbox360-controller-driver-improved branch January 27, 2016 21:54
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants