Attempt clearer language for fetch and resources #16389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amorymeltzer
force-pushed
the
clarify-resources
branch
from
c041cb3 to
98d7b9d
Compare
| @@ -67,12 +67,12 @@ Note that `uninstall --force` is currently imperfect. See the man page for more | |||
|
|
|||
| * `info` — displays information about the given Cask | |||
| * `list` — with no args, lists installed Casks; given installed Casks, lists staged files | |||
| * `fetch` — downloads Cask resources to local cache (with `--force`, re-download even if already cached) | |||
| * `fetch` — downloads files containing Cask applications to local cache (with `--force`, re-download even if already cached) | |||
There was a problem hiding this comment.
“files containing Cask applications” is confusing to me.
“downloads files need to install applications to local cache (with --force, re-download even if already cached)”?
There was a problem hiding this comment.
Better yet, why not just steal directly from the manpage? “download remote application files for the given Cask to the local cache (with --force, re-download even if already cached)” seems pretty clear to me.
There was a problem hiding this comment.
Hmm, I like that latter suggestion a lot.
Amorymeltzer
force-pushed
the
clarify-resources
branch
from
98d7b9d to
b961fd0
Compare
Amorymeltzer
force-pushed
the
clarify-resources
branch
from
b961fd0 to
cc589ca
Compare
vitorgalvao
added a commit
that referenced
this pull request
Jan 6, 2016
Attempt clearer language for fetch and resources
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was never particularly clear to me what "resources" meant, in part because I think it was used over-broadly. Maybe I'm the outlier, but two years later I'm still confused.
Happy to entertain alternative language choices here, I'm not wed to these.