-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade URLs to HTTPS, remove exec flags #175136
Conversation
Thank you for opening this @vszakats - looks like CI has picked up an issue with |
Thanks, I'll be looking at the two fallouts, but breaking this into ~35 PRs is probably something out of my capacity. We used to handle these in batches back in the days, mainly not to overload Jenkins. |
As mentioned in the other PR, we aren't asking for one PR per formula/cask, but one |
Regarding the fallouts, they both seem pre-existing and not caused by this PR. Maybe dropping both from this PR is the best, even though this PR would still improve their state despite their existing issues. What do you think? |
We can't merge when CI is ❌, so splitting to another PR is probably best in those cases. |
OK, split to one commit per file and dropped the two broken ones. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.This mainly aims to fix the regression for the insecure link introduced for VMware Fusion 13.5.2. Then also run my old URL upgrader script (that I used here in the past) on the whole repo and bumped other insecure links that have secure alternatives.