lyrics-master: update livecheck #190249
Merged
lyrics-master: update livecheck #190249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `livecheck` block for `lyrics-master` was recently updated but in the process the case-insensitive regex flag was mistakenly removed. We enforce case sensitive regexes by default in livecheck RuboCops (and provide a file to opt a package out when case sensitivity is necessary) but they don't apply to casks yet. I'm currently working on making that happen but I'm cleaning up style offenses in the interim time. I recently did a pass to address regexes that don't have the `i` flag but this instance was introduced after the most recent pass. Thankfully `brew style` will catch this in the future and prevent regressions but we're not there yet.
bevanjkay
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.The
livecheckblock forlyrics-masterwas recently updated but in the process the case-insensitive regex flag was mistakenly removed. We enforce case sensitive regexes by default in livecheck RuboCops (and provide a file to opt a package out when case sensitivity is necessary) but they don't apply to casks yet.I'm currently working on making that happen but I'm cleaning up style offenses in the interim time. I recently did a pass to address regexes that don't have the
iflag but this instance was introduced after the most recent pass. Thankfullybrew stylewill catch this in the future and prevent regressions but we're not there yet.