Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniconda: update livecheck #190251

Merged
merged 1 commit into from
Oct 30, 2024
Merged

miniconda: update livecheck #190251

merged 1 commit into from
Oct 30, 2024

Conversation

samford
Copy link
Member

@samford samford commented Oct 30, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

The existing livecheck block for miniconda contains a #strategy call but it doesn't specify a strategy symbol. We expect the symbol to always be provided when #strategy is used but we enforce this using a RuboCop and the livecheck block RuboCops don't apply to casks yet (I'm currently working on this).

This adds the missing #strategy symbol and renames the strategy block argument to use the standard page name for PageMatch.

The existing `livecheck` block for `miniconda` contains a `#strategy`
call but it doesn't specify a strategy symbol. We expect the symbol to
always be provided when `#strategy` is used but we enforce this using
a RuboCop and the `livecheck` block RuboCops don't apply to casks yet
(I'm currently working on this).

This adds the missing `#strategy` symbol and renames the `strategy`
block argument to use the standard `page` name for `PageMatch`.
@samford samford added the livecheck Issues or PRs related to livecheck label Oct 30, 2024
@bevanjkay bevanjkay enabled auto-merge October 30, 2024 02:12
@bevanjkay bevanjkay merged commit 150c8b8 into master Oct 30, 2024
8 checks passed
@bevanjkay bevanjkay deleted the miniconda-update-livecheck branch October 30, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants