Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purevpn: update version, livecheck #195248

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

AlternateRT
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


This PR removes the livecheck block and changes the version to :latest because the page used for livechecking is often outdated for months with no end - the page was last updated over two months ago, and since that time, two newer versions have come out.

I left the block commented to remember the URL, just in case the page is properly updated in the future.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Dec 14, 2024
@bevanjkay
Copy link
Member

bevanjkay commented Dec 14, 2024

Rather than removing the livecheck, we could try to use the extract_plist livecheck strategy on the url, if it returns the correct version it is likely the best option here.

@krehel krehel changed the title purevpn: remove livecheck purevpn: update version, livecheck Dec 14, 2024
@khipp khipp merged commit 267a410 into Homebrew:master Dec 14, 2024
11 checks passed
@AlternateRT
Copy link
Contributor Author

Sorry for disappearing almost immediately after creating this PR 😅

Just for future reference, using :extract_plist livecheck is still preferred over using version :latest? When I opened this, I refrained from changing the livecheck back to :extract_plist because of #171006 and #180264.

My thinking was that since :extract_plist should only be used as a very last resort due to how costly it is, and this cask was already moved away from using, then using version :latest would have been preferable; the download URL is already unversioned after all, and always provides the latest version.

@AlternateRT AlternateRT deleted the purevpn-latest branch December 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extract_plist livecheck livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants