Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAB containers #1992

Merged
merged 1 commit into from
Feb 8, 2014
Merged

CAB containers #1992

merged 1 commit into from
Feb 8, 2014

Conversation

rolandwalker
Copy link
Contributor

This PR contains a major change - it adds a dependency to brew-cask itself.
Therefore I assume this PR needs some discussion and may not be accepted.
The added dependency is "cabextract", available through the homebrew
ecosystem. The gain is the ability to install CAB archives. CABs are
typically Windows-specific. However, there will be another commit in this
branch showing an example of when installing a CAB in OS X might be useful.

@fanquake
Copy link
Contributor

Given that fonts have moved to https://github.com/caskroom/homebrew-fonts, you'll need to remove the Verdana commit from this pull.

@rolandwalker
Copy link
Contributor Author

This has now been completely rewritten in light of #2305.

Tests were added, and the default Travis environment was changed to install the cabextract binary. If the user of rake test does not have cabextract installed, the relevant test is skipped.

Fonts were also removed from this PR as they will be submitted separately to the fonts repo.

@rolandwalker rolandwalker mentioned this pull request Feb 7, 2014
@phinze
Copy link
Contributor

phinze commented Feb 8, 2014

Solid. 💼

phinze added a commit that referenced this pull request Feb 8, 2014
@phinze phinze merged commit 9faa44e into Homebrew:master Feb 8, 2014
@rolandwalker rolandwalker deleted the core_fonts branch February 8, 2014 18:30
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants