Delete exceptions from homebrew-fork #22574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏 It's also worth noting that when Homebrew/brew#390 is merged we'll be verifying that Homebrew's core changes don't end up breaking |
| @@ -3,6 +3,7 @@ require 'rake/testtask' | |||
| require 'rspec/core/rake_task' | |||
| require 'rubocop/rake_task' | |||
|
|
|||
| $LOAD_PATH.unshift(File.expand_path('../../../../Homebrew', __FILE__)) | |||
There was a problem hiding this comment.
There's no guarantee that tests are being run from the tap repo. For example, I have a separate clone in a common directory for Git projects where I do most of my development, so this wouldn't work for me.
Better, I think, to do this:
homebrew_repo = `brew --repository`
$LOAD_PATH.unshift(File.expand_path("#{homebrew_repo}/Library/Homebrew"))
fanquake
added
the
core
fanquake
changed the title
|
Great work, thanks! |
miccal
removed
awaiting user reply
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the core
Using exceptions from homebrew now as a preparation to core merge(#14384).