Fix uninstall not working when version changes.

[reitermarkus]

Changes to the core

• Followed hacking.md.

---

Todo

• Add test for message when other versions remain installed.
• Add test for uninstalling multiple versions consecutively.

---

#2988
#14058

[jawshooah]

Why reverse twice? Isn't .uniq.reverse sufficient?

[reitermarkus]

Consider this:

timestamped_versions = [['a', '1'], ['b', '2'], ['a', '3']]

timestamped_versions.map(&:first) --> ['a', 'b', 'a']
                    .uniq         --> ['a', 'b']

Now, .last doesn't actually return the version which was installed last.

[jawshooah]

Ah, gotcha.

[jawshooah]

I think a change of this magnitude warrants some new tests. Once those are added and the currently failing tests are fixed, I'm all for merging this 👍

[reitermarkus]

@jawshooah, what exactly is PERSISTENT_METADATA_SUBDIRS? Is the gpg sub-directory used for anything else than signature.asc?

According to fetch_sig in gpg.rb, this is only used for caching. Wouldn't Hbc.cache be a better place for signature.asc files?

[jawshooah]

@reitermarkus I'm not sure. Looks like it was added in #6117 "to provide persistent per-distribution locations to for GPG data". I'd be fine with moving the signature file to Hbc.cache

[reitermarkus]

Ah, I had an error in thinking:

I thought the gpg directory would be atcaskroom/cask/.metadata/gpg, which would result in a conflict when globbing the .metadata directory to retreive timestamped versions.

But actually it's stored at caskroom/cask/.metadata/version/timestamp/gpg, so there's no conflict.

Still, there's not much use keeping persistent data in a timestamped directory.

[reitermarkus]

@jawshooah, could you take a look at the test I have added (and the one I have altered)?

Also, not sure what would be the best way to reuse the code from the uninstalls one version at a time. MiniTest doesn't have a before(:each), right?

Or should I simply add the test for the cask 1.2.3 is still installed message into the existing one?

[reitermarkus]

Ok, apparently after and before are equivalent to teardown and setup. Strange thing is, after and before are working, teardown and setup are not.

[jawshooah]

@reitermarkus LGTM, merge when ready 👍

[reitermarkus]

This pull request was merged in 36a98c5...1835d6d.