Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make brew cask install --force to redownload the file #2528

Closed
wants to merge 1 commit into from

Conversation

voanhduy1512
Copy link
Contributor

As suggestion in #1692, i make brew install --force to redownload file. With this we will one step nearer to brew cask upgrade #309

@phinze
Copy link
Contributor

phinze commented Feb 8, 2014

This seems like reasonable behavior, and I'd be +1 to merge it if we can get covering tests and some docs for the option. 🎨

@rolandwalker
Copy link
Contributor

👍 from me as well -- the user needs this ability -- but I think that --force is not the right interface. Some downloads are very long, and the user does not need to repeat the download merely to do a --force for other reasons.

Some alternative interfaces could be

  • new option --force-download . One could also imagine --force-checksum and --force-all
  • new command verb brew cask download <cask>

In part the user finds this to be a problem because downloads hang around too long, which we are starting to address in #2759. Both directions are good.

@voanhduy1512
Copy link
Contributor Author

i wonder do --force-download must go with --force, because if i --force-download but don't --force then it just download and don't install.
So do you want --force-download included --force or we remind user to declare them together?

@voanhduy1512
Copy link
Contributor Author

And i can provide the doc (once we solve problem above), but i don't know how to test redownload. Can you give me some advise?

@rolandwalker
Copy link
Contributor

@voanhduy1512 I lost you on IRC -- call me back.

I looked up how Homebrew handles this functionality: the fetch command, documented here https://github.com/Homebrew/homebrew/blob/master/Library/Contributions/manpages/brew.1.md#commands . fetch usually happens automatically when the user gives install, but it is possible to give fetch by itself. If you give fetch --force, then it forces the download.

So for consistency with Homebrew, we should probably follow that interface. (BTW it is the same interface as the BSD port package manager.)

voanhduy1512 pushed a commit to voanhduy1512/homebrew-cask that referenced this pull request Feb 15, 2014
Add `fetch` command to cli like suggestion at the end of Homebrew#2528
@voanhduy1512 voanhduy1512 mentioned this pull request Feb 15, 2014
@voanhduy1512
Copy link
Contributor Author

Closed this issue as interface change, see #2970

voanhduy1512 pushed a commit to voanhduy1512/homebrew-cask that referenced this pull request Feb 25, 2014
Add `fetch` command to cli like suggestion at the end of Homebrew#2528
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants