Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add before_install and before_uninstall #2742

Merged
merged 1 commit into from
Feb 13, 2014

Conversation

rolandwalker
Copy link
Contributor

This is intended as a tool to force some truly odd cases like #2654. (The container is weird, we need to pre-preprocess it).

I intentionally left this undocumented for now in case we think of a better way to do this, for example as an extension to #2649.

@vmrob
Copy link
Contributor

vmrob commented Feb 7, 2014

I think this sounds like a great feature, though out of curiosity, with respect to the oddities of the aforementioned dmg, why not just attempt opening it read-only and then use the default as a fallback option?

@rolandwalker
Copy link
Contributor Author

Because I'm assuming two things

  1. @phinze had a good reason for only allowing read-only mounts
  2. there will be other odd cases where we want the before_install hammer

@rolandwalker rolandwalker mentioned this pull request Feb 7, 2014
@phinze
Copy link
Contributor

phinze commented Feb 13, 2014

Yeah +1 @rolandwalker I'd rather capture the oddity of this particular dmg inside the Cask definition rather than adding complexity to the code run for every Cask.

The idea for these sort of blocks is that we can capture edge cases and then take stock - if we find ourselves doing a pattern many times, we can promote it to the official DSL or the standard code path.

rolandwalker added a commit that referenced this pull request Feb 13, 2014
add `before_install` and `before_uninstall`
@rolandwalker rolandwalker merged commit 82b9d30 into Homebrew:master Feb 13, 2014
@rolandwalker rolandwalker deleted the before_install branch February 13, 2014 16:19
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants