Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cask for The Archive Browser #2815

Merged
merged 1 commit into from
Feb 10, 2014

Conversation

poltak
Copy link
Contributor

@poltak poltak commented Feb 8, 2014

New cask for paid app 'The Archive Browser'. Installs a 30 day trial version, in which the user is prompted for a license number they can purchase.

DISCLAIMER: I am not affiliated with 'The Archive Browser' project or the developers. I am simply an end-user.

@rolandwalker
Copy link
Contributor

Thanks for the contribution!

I'm going to delay merging this Cask to give other folks a chance to comment on your novel use of caveats here.

If this becomes a common use of caveats, I would add something standard to the caveats DSL, though my preference is ultimately to do something like what is discussed in #2812.

@nanoxd
Copy link
Contributor

nanoxd commented Feb 8, 2014

Thank you for your contribution.

There is no harm in indicating that an application is a trial but I think that can be said for most casks. It would help with #2812 in indicating whether an application is a demo/trial.

I don't feel these features are in-line with the project's goal: "Let's see if we can get the elegance, simplicity, and speed of Homebrew for the installation and management of GUI Mac applications such as Google Chrome and Adium." @vitorgalvao and I both agreed before that homebrew-cask is less of an application discovery tool like Bodega and more of an automation tool.

@rolandwalker
Copy link
Contributor

@nanoxd , just to make sure we are on the same page: I agree about not turning homebrew-cask into a discovery tool. I tried to be clear in #2812 that :license or :tags must be constrained to a defined set. The purpose would be more for filtering/user-control than discovery.

In my mind, I see licenses as technical points, specific to each Cask, very similar to say, the need to reboot: "constraints which apply to the use of this Cask".

@nanoxd
Copy link
Contributor

nanoxd commented Feb 10, 2014

@rolandwalker In that case, we are on the same page. The more information about the software, the better!

@rolandwalker
Copy link
Contributor

Great! I'm going to merge this Cask. We can further discuss & work on standardizing license/tag/caveats/whatever-it-may-be in another PR.

@poltak , thank you for your contribution!

rolandwalker added a commit that referenced this pull request Feb 10, 2014
Added cask for The Archive Browser
@rolandwalker rolandwalker merged commit df20196 into Homebrew:master Feb 10, 2014
@poltak
Copy link
Contributor Author

poltak commented Feb 10, 2014

Thanks for the patience in explaining and the transparency with your decision process.
Much appreciated.

@poltak poltak deleted the the-archive-browser branch February 10, 2014 01:36
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants