More effective install-time workaround for Java #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks for this -- I applaud your hacktitude here! Some quibbles:
uninstall :pkgutil => 'com.oracle.jdk7u51',
:files => '/System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK' |
|
I've addressed those issues, @rolandwalker, thanks! |
|
Could you also be so kind as to squash this awesomeness into one commit? |
* Use `ln` and `PlistBuddy` to establish JDK 7 as the system Java * Use current Java version for linking current JDK * Properly clean up after uninstall
|
Done. |
|
Great, thanks! I'm going to leave this PR open for a while before merging so people have a chance to admire it. |
rolandwalker
added a commit
that referenced
this pull request
Feb 10, 2014
More effective install-time workaround for Java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
PlistBuddyand somelnjiggery-pokery to make JDK 7 the bulletproof default JDK on supported versions of OS X. Not dead-set on this getting merged, but it certainly makes my life easier - following installation of this modified Cask, subsequent installation ofandroid-studio,appcode,eclipse-ireare tested to work immediately with potentially no Info.plistsed-ing.