Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use no_checksum instead of a sha1 when getting latest version. #300

Merged
merged 2 commits into from
May 10, 2013
Merged

Use no_checksum instead of a sha1 when getting latest version. #300

merged 2 commits into from
May 10, 2013

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented May 10, 2013

installation currently fails because of a SHA mismatch

> brew cask install mou
==> Downloading http://mouapp.com/download/Mou.zip
######################################################################## 100.0%
Error: SHA1 mismatch
Expected: e69bc2bbdadea6a2929032506085b6e9501a7fb9
Actual: 1276772fe649b2556257f6c0cf6e3ad5998fa35b

We've already dropped the explicit version. It seems to follow to drop the explicit SHA.

@vitorgalvao
Copy link
Member

Since you’re already editing it, would you mind adding the link line, as it’ll be a requirement? You can also see some examples on how to do it.

@vitorgalvao
Copy link
Member

Thank your for the changes. Merged.

vitorgalvao added a commit that referenced this pull request May 10, 2013
Use `no_checksum` instead of a sha1 when getting `latest` version.
@vitorgalvao vitorgalvao merged commit 19b26b5 into Homebrew:master May 10, 2013
@jfsiii jfsiii deleted the fix-mou branch May 10, 2013 01:00
@jfsiii
Copy link
Contributor Author

jfsiii commented May 10, 2013

This is a bit embarrassing but, how do I get brew cask install mou to respect this cask and not the one installed at ``brew --prefix/Cellar/brew-cask/0.10.0/Casks/mou.rb?

± ~/Sites/homebrew-cask [master @ 19b26b5] ✓ ‣ cat `brew --prefix`/Cellar/brew-cask/0.10.0/Casks/mou.rb
class Mou < Cask
  url 'http://mouapp.com/download/Mou.zip'
  version 'latest'
  homepage 'http://mouapp.com/'
  sha1 'e69bc2bbdadea6a2929032506085b6e9501a7fb9'
end
± ~/Sites/homebrew-cask [master @ 19b26b5] ✓ ‣ cat Casks/mou.rb
class Mou < Cask
  url 'http://mouapp.com/download/Mou.zip'
  version 'latest'
  homepage 'http://mouapp.com/'
  no_checksum
  link :app, 'Mou.app'
end

@passcod
Copy link
Contributor

passcod commented May 10, 2013

It doesn't use the one at .../Cellar/brew-cask/0.10.0/Casks/mou.rb, but rather the one at .../Taps/phinze-cask/Casks/mou.rb, which is updated with the normal flow: brew update.

@jfsiii
Copy link
Contributor Author

jfsiii commented May 10, 2013

Ah, thanks.

The issues seemed to be that

  • I blindly followed the instructions in CONTRIBUTING.md
  • CONTRIBUTING.md uses /usr/local instead of brew --prefix.

I switched to brew --prefix and everything went well:

± ~/Sites/homebrew-cask [master @ 19b26b5] ✗ ‣ brew cask install mou
==> Downloading http://mouapp.com/download/Mou.zip
Already downloaded: /Library/Caches/Homebrew/mou-latest.zip
caution: excluded filename not matched:  __MACOSX/*
==> Success! mou installed to /opt/homebrew-cask/Caskroom/mou/latest
==> Linking Mou.app to /Users/jschulz/Applications/Mou.app

I'll update CONTRIBUTING.md and send a PR.

@jfsiii
Copy link
Contributor Author

jfsiii commented May 10, 2013

To be fair, the issues I referenced above are the reason I had to send the PR without actually seeing the app actually install 😇

brew update did work. I had an issue which was preventing brew update from running properly. Once I fixed it, brew cask install mou worked as shown.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants