Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cask for WebKit Nightly. #308

Closed
wants to merge 1 commit into from
Closed

Add a cask for WebKit Nightly. #308

wants to merge 1 commit into from

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented May 12, 2013

No description provided.

@vitorgalvao
Copy link
Member

'latest' is useful for apps that update and don’t change the download url. That really isn’t the case, here — it has a version, it just is a short‐lived one.

@jfsiii
Copy link
Contributor Author

jfsiii commented May 12, 2013

nod

I wasn't sure what to do. I rationalized it as:

  • While the URL does change, the user's intent (to get the latest Nightly) does not.
  • This app automatically checks for updates and prompts to download the latest version.
  • There is so much churn, it is a nightly, that accuracy seems to require constant updating.

I'm definitely the new guy here. That's just how I thought about it.

@vitorgalvao
Copy link
Member

Don’t worry about it, it’s not a big issue, and I certainly understand your thought process.

However, if you’re classifying it as being “latest”, then it should also have “no_checksum” applied (like, for example, the github cask), as is usually done with “latest version casks”.

On the other hand, people who install this cask will always get that version of the nightly, until the url breaks (even today a firefox-aurora link had to be replaced for this reason) or the cask is updated, so including the version number might give a sense of how old it actually is.

@jfsiii
Copy link
Contributor Author

jfsiii commented May 12, 2013

Yeah, I saw that firefox-aurora commit. And it's why I didn't create a firefox-nightly cask. It makes the recipes expire so quickly.

Is this covered territory? @phinze? Is there anyway to add logic (e.g. run bash, ruby, etc) to the casks? Some way I could better generalize the handling of the versioning and URLs?

@joeyhoer
Copy link
Contributor

Looking forward to this addition. Problem is - WebKit Nightly is updated so frequently, that this would be a nightmare to maintain. I'm in agreement with @jfsiii, and I would also be interested to know if there is a way to add logic to the casks.

curl http://nightly.webkit.org/ | grep dmg | head -1 | perl -pe 's/.*(http.*dmg).*/$1/'

The method above is what I've been using to parse the URL - I don't like that it's so dependent upon the web markup, but it's the best way that I know of.

@vitorgalvao
Copy link
Member

@joeyhoer #142 is the relevant issue you might want to refer to, for further discussion on the feature.

@joeyhoer
Copy link
Contributor

@vitorgalvao Absolutely, I'll go continue the discussion there. I wanted to drop some relevant code here, it might be useful in the future:

class WebkitNightly < Cask
  url %x( curl -s http://nightly.webkit.org/ | grep dmg | head -1 | perl -pe 's/.*(http.*dmg).*/$1/' )
  homepage 'http://nightly.webkit.org'
  version 'latest'
  no_checksum
  link 'WebKit.app'
end

That'll always pull the latest version, unless of course they change something about that page, in which case, we can just update the cask. It will require much less frequent updating, and thus is the advantage of keeping the casks in ruby.

@vitorgalvao vitorgalvao mentioned this pull request Oct 6, 2013
@phinze
Copy link
Contributor

phinze commented Oct 21, 2013

So Webkit could make this so much easier on us if they would just provide a stable latest URL for a download. Then we could do this:

class WebkitNightly < Cask
  url 'http://builds.nightly.webkit.org/files/trunk/mac/WebKit-SVN-latest.dmg'
  homepage 'http://nightly.webkit.org'
  version 'latest'
  no_checksum
  link 'WebKit.app'
end

Plenty of projects do this - pretty sure it's as simple as adding a symlink to the nightly build process. Anybody want to head over to WebKit and see if they might be willing to look into it?

@nanoxd
Copy link
Contributor

nanoxd commented Nov 10, 2013

@shrx In the future please open up an issue specific to the cask. firefox-nightly has been moved to caskroom/homebrew-versions.

@rolandwalker
Copy link
Contributor

webkit-nightly has been addressed in Homebrew/homebrew-cask-versions#30

@nanoxd
Copy link
Contributor

nanoxd commented Nov 26, 2013

@rolandwalker Thanks for the update.

@nanoxd nanoxd closed this Nov 26, 2013
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants