-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cask for WebKit Nightly. #308
Conversation
|
nod I wasn't sure what to do. I rationalized it as:
I'm definitely the new guy here. That's just how I thought about it. |
Don’t worry about it, it’s not a big issue, and I certainly understand your thought process. However, if you’re classifying it as being “latest”, then it should also have “no_checksum” applied (like, for example, the github cask), as is usually done with “latest version casks”. On the other hand, people who install this cask will always get that version of the nightly, until the url breaks (even today a firefox-aurora link had to be replaced for this reason) or the cask is updated, so including the version number might give a sense of how old it actually is. |
Yeah, I saw that Is this covered territory? @phinze? Is there anyway to add logic (e.g. run bash, ruby, etc) to the casks? Some way I could better generalize the handling of the versioning and URLs? |
Looking forward to this addition. Problem is - WebKit Nightly is updated so frequently, that this would be a nightmare to maintain. I'm in agreement with @jfsiii, and I would also be interested to know if there is a way to add logic to the casks.
The method above is what I've been using to parse the URL - I don't like that it's so dependent upon the web markup, but it's the best way that I know of. |
@vitorgalvao Absolutely, I'll go continue the discussion there. I wanted to drop some relevant code here, it might be useful in the future:
That'll always pull the latest version, unless of course they change something about that page, in which case, we can just update the cask. It will require much less frequent updating, and thus is the advantage of keeping the casks in ruby. |
So Webkit could make this so much easier on us if they would just provide a stable class WebkitNightly < Cask
url 'http://builds.nightly.webkit.org/files/trunk/mac/WebKit-SVN-latest.dmg'
homepage 'http://nightly.webkit.org'
version 'latest'
no_checksum
link 'WebKit.app'
end Plenty of projects do this - pretty sure it's as simple as adding a symlink to the nightly build process. Anybody want to head over to WebKit and see if they might be willing to look into it? |
@shrx In the future please open up an issue specific to the cask. |
webkit-nightly has been addressed in Homebrew/homebrew-cask-versions#30 |
@rolandwalker Thanks for the update. |
No description provided.