Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom.us #3259

Merged
merged 1 commit into from
Feb 27, 2014
Merged

Add zoom.us #3259

merged 1 commit into from
Feb 27, 2014

Conversation

conormcd
Copy link
Contributor

Cask for zoom, a video conferencing tool.

@rolandwalker
Copy link
Contributor

Hi! Many thanks for the submission!

Since this installs an App named "zoom.us.app", would you mind renaming the Cask to zoomus.rb (and change the first line to class Zoomus < Cask?

The Cask naming rules are laid out in CONTRIBUTING.md, but they have been changing lately, so it's not surprising if you missed some recent amendments. The doc is also less clear about pkg files, something we need to fix.

Also, it would be good to add an uninstall stanza to this Cask so that brew cask uninstall can work:

  uninstall :files => '/Applications/zoom.us.app'

@rolandwalker
Copy link
Contributor

Now I see that this pkg does some weird things, symlinking the name Zoom to the app bundle zoom.us.app.

@conormcd
Copy link
Contributor Author

Yeah! The symlink on the desktop is quite obnoxious. I'll make, squash and push those other changes now.

Cask for zoom, a video conferencing tool.
@conormcd
Copy link
Contributor Author

@rolandwalker Changes made.

@rolandwalker
Copy link
Contributor

Thanks!

rolandwalker added a commit that referenced this pull request Feb 27, 2014
@rolandwalker rolandwalker merged commit f823b25 into Homebrew:master Feb 27, 2014
@rolandwalker
Copy link
Contributor

After #3011 is merged, I think we can sidestep the weird stuff this installer does.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants