devscript: add cask_namer
#3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| The easiest way to name a Cask is to run this command: | ||
| ```bash | ||
| $ /usr/local/Library/Taps/phinze-cask/developer/bin/cask_namer '/full/path/to/new/software.app' |
There was a problem hiding this comment.
/usr/local/Library/Taps/phinze-cask/developer/bin/cask_namer should be $(brew --prefix)/Library/Taps/phinze-cask/developer/bin/cask_namer.
|
Looking good. The amount of work you’ve been putting into this is commendable. |
This script implements naming rules for App-based Casks as currently documented. After some real-world testing, this logic should be merged into `brew cask create`. This commit adds `doc/CASK_NAMING_REFERENCE.md`, and reduces `CONTRIBUTING.md` by 422 words.
|
"Quantity has a quality all its own". Oh, one rule sneaked into this PR that we didn't discuss: removing trailing "app" from the name (separate from the extension |
|
In this case, it has been a high quantity of high quality work. Yes, I very much agree with that (I actually thought we had discussed it). |
rolandwalker
added a commit
that referenced
this pull request
Mar 10, 2014
devscript: add `cask_namer`
Closed
87 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script implements naming rules for App-based Casks
as currently documented. After some real-world testing, this
logic should be merged into
brew cask create. This commit addsdoc/CASK_NAMING_REFERENCE.md, and reducesCONTRIBUTING.mdby422 words.
@vitorgalvao here is the result of our efforts. This script correctly predicts
the current names of all but 18
link-based Casks (less than 2%).It also checks the current repo for name collisions. The logic is
idempotent in that (although the script is designed to accept App paths),
correctly formed Cask names will pass through unchanged. This is an
important criterion for any future merger with
brew cask create.