Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Istio 0.4.0 ( https://istio.io ) #42802

Closed
wants to merge 1 commit into from
Closed

Add Istio 0.4.0 ( https://istio.io ) #42802

wants to merge 1 commit into from

Conversation

MPV
Copy link
Contributor

@MPV MPV commented Jan 14, 2018

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@commitay
Copy link
Contributor

Rejected Casks
The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).

@commitay commitay closed this Jan 14, 2018
@MPV
Copy link
Contributor Author

MPV commented Jan 14, 2018

@commitay: Thanks for reviewing this.

You can find Istio (as binary at least) rejected by Homebrew/core here: Homebrew/homebrew-core#16586 (and it was suggested by someone to be a Cask instead).

@commitay
Copy link
Contributor

commitay commented Jan 14, 2018

You can find Istio (as binary at least) rejected by Homebrew/core

Homebrew formulas build software from source.

Please submit this to Homebrew/core building from source or consider creating your own tap.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants