Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandoc: add caveats about pandoc formula in homebrew #4451

Merged
merged 1 commit into from
May 21, 2014
Merged

pandoc: add caveats about pandoc formula in homebrew #4451

merged 1 commit into from
May 21, 2014

Conversation

xu-cheng
Copy link
Member

No description provided.

@tapeinosyne
Copy link
Contributor

I think that this specific caveat is unnecessary, as the conflict between multiple binaries is basic and commonly understood; warnings on the matter are usually left unstated in software distribution.

Nonetheless, if we decide to merge, we should remember that the same rationale would apply to many other casks.

@rolandwalker
Copy link
Contributor

This change would seem to be modeled on the caveats in macvim.rb.

We apparently don't have a specific policy on the these caveats, and @ndr-qef is right, they are not uniform.

The ideal solution would be a conflicts_with :formula addition to the DSL, yes?

In the meantime, I think @xu-cheng is trying to help a first-time user. I would merge this, with the idea that it could be deleted in the future, when conflicts_with :formula is implemented.

@tapeinosyne
Copy link
Contributor

The underlying issue is larger: all package managers that can install globally are a potential source of conflict. @xu-cheng's contribution is a particularly good example, as Pandoc can be installed with Homebrew, Homebrew Cask, and Cabal.

However, I recognize that it might be desirable to tackle Homebrew specifically. If we decide to do it, I agree that we should merge this —and amend the docs, possibly— while we extend the DSL.

@rolandwalker
Copy link
Contributor

I agree about other package managers; we should only worry about Homebrew.

And I point out a limitation of caveats/conflicts_with :formula : we check for conflict with Homebrew Formulae, but it goes only one way. Homebrew does not and will not check for conflicts with Casks.

@rolandwalker
Copy link
Contributor

Merging this and filing some other issues as discussed.

Thanks @xu-cheng !

rolandwalker added a commit that referenced this pull request May 21, 2014
pandoc: add caveats about pandoc formula in homebrew
@rolandwalker rolandwalker merged commit e222fa4 into Homebrew:master May 21, 2014
@xu-cheng xu-cheng deleted the pandoc branch May 22, 2014 04:38
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants