Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHDL 0.35 #46031

Closed
wants to merge 3 commits into from
Closed

Update GHDL 0.35 #46031

wants to merge 3 commits into from

Conversation

sww1235
Copy link
Contributor

@sww1235 sww1235 commented Apr 17, 2018

Wasn't able to audit or check style due to editing purely via github.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@sww1235
Copy link
Contributor Author

sww1235 commented Apr 17, 2018

The GHDL project changed to a github organization, thus I could not use cask-repair.

I am not certain exactly how to add the artifact stanza correctly.

Also a question. This application does not seem to fit in homebrew casks, as it does not provide a .app, it just provides binary files. This seems like a better fit now for normal homebrew.

@commitay commitay added the awaiting maintainer feedback Issue needs response from a maintainer. label Apr 17, 2018
@commitay
Copy link
Contributor

This application does not seem to fit in homebrew casks, as it does not provide a .app, it just provides binary files. This seems like a better fit now for normal homebrew.

Agreed.

@vitorgalvao Should we remove this?

@vitorgalvao
Copy link
Member

This seems like a better fit now for normal homebrew.

That is correct. The policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).

The GHDL project changed to a github organization, thus I could not use cask-repair.

What do you mean? cask-repair doesn‘t care.

Should we remove this?

Yes. @sww1235 Will you submit to Homebrew/core?

@sww1235
Copy link
Contributor Author

sww1235 commented Apr 17, 2018

I am working on submitting to homebrew/core, but I believe I have discovered the reason why this is in homebrew-casks in the first place.

GHDL is written almost entirely in Ada, which requires a special compiler from GCC. There is no similar support for LLVM/clang as far as I can tell.

I have submitted a discourse post asking for assistance on using a specific compiler, and will keep this pull request updated with any further info I find.

@adidalal adidalal added awaiting user reply Issue needs response from a user. on hold and removed awaiting maintainer feedback Issue needs response from a maintainer. labels Apr 19, 2018
@commitay
Copy link
Contributor

@commitay
Copy link
Contributor

Adding ada to gcc is possible but it's kind of niche and would further complicate an already complex (and popular) formula.

Cask can install the binaries but installing includes and libs probably isn't something we want to do.

I think the best way forward would be for this to removed from Cask in favour of a third-party formula that can perform a complete install of upstreams pre-built tarball.

@commitay commitay added awaiting maintainer feedback Issue needs response from a maintainer. and removed on hold awaiting user reply Issue needs response from a user. labels May 13, 2018
@vitorgalvao
Copy link
Member

Fine with removal.

@commitay commitay mentioned this pull request May 14, 2018
@commitay commitay removed the awaiting maintainer feedback Issue needs response from a maintainer. label May 14, 2018
@sww1235
Copy link
Contributor Author

sww1235 commented May 16, 2018

Thank you for working on this. I understand that it doesn't necessarily fit under cask or will work in core.

@sww1235 sww1235 deleted the Update-GHDL-0.35 branch May 16, 2018 23:52
@Homebrew Homebrew locked and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants