-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GHDL 0.35 #46031
Update GHDL 0.35 #46031
Conversation
Updating to master
The GHDL project changed to a github organization, thus I could not use cask-repair. I am not certain exactly how to add the artifact stanza correctly. Also a question. This application does not seem to fit in homebrew casks, as it does not provide a .app, it just provides binary files. This seems like a better fit now for normal homebrew. |
Agreed. @vitorgalvao Should we remove this? |
That is correct. The policy is documented in faq/rejected_casks:
What do you mean?
Yes. @sww1235 Will you submit to Homebrew/core? |
I am working on submitting to homebrew/core, but I believe I have discovered the reason why this is in homebrew-casks in the first place. GHDL is written almost entirely in Ada, which requires a special compiler from GCC. There is no similar support for LLVM/clang as far as I can tell. I have submitted a discourse post asking for assistance on using a specific compiler, and will keep this pull request updated with any further info I find. |
Adding ada to gcc is possible but it's kind of niche and would further complicate an already complex (and popular) formula. Cask can install the binaries but installing includes and libs probably isn't something we want to do. I think the best way forward would be for this to removed from Cask in favour of a third-party formula that can perform a complete install of upstreams pre-built tarball. |
Fine with removal. |
Thank you for working on this. I understand that it doesn't necessarily fit under cask or will work in core. |
Wasn't able to audit or check style due to editing purely via github.
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}
worked successfully.brew cask uninstall {{cask_file}}
worked successfully.