DSL: remove special properties of caskroom_only stanza
#4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HOLD until Homebrew#4865 is merged. After Homebrew#4865, `caskroom_only` can be subclassed from Cask::Artifact::Base like any other artifact. It no longer has the special property of making `uninstall` stanzas work. This stanza has never been documented. It is possible that it will no longer be needed, after Homebrew#4865 and subsequent cleanup on Casks that use this form. References: Homebrew#4688
rolandwalker
changed the title
caskroom_only stanzacaskroom_only stanza
rolandwalker
added a commit
that referenced
this pull request
Jun 28, 2014
DSL: remove special properties of `caskroom_only` stanza
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOLD until #4865 is merged. The test suite passes, but this would actually
break some unusual Casks without #4865.
After #4865,
caskroom_onlycan be subclassed fromCask::Artifact::Baselike any other artifact. It no longer has the special property of making
uninstallstanzas work.This stanza has never been documented. It is possible that it will no longer
be needed, after #4865 and subsequent cleanup on Casks that use this form.
References: #4688