DSL: add license stanza
#4873
Merged
DSL: add license stanza
#4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,42 @@ | |||
| class Cask::License | |||
|
|
|||
| VALID_LICENSES = [ | |||
There was a problem hiding this comment.
Why not use Set? It's faster and would ensure that there are no duplicate values. See this post
There was a problem hiding this comment.
Probably a good idea. Performance matters when an operation instantiates many Casks.
References: Homebrew#4688. For forward-compatibility; intentionally left undocumented. The `license` stanza is not free-form. There is a limited set of valid symbols, of which the argument must be a member. (The set will later be documented, and probably needs amendments.) Version numbers and variants of licenses are intentionally ommitted. The use-case for `license` is filtering and listing of Casks. We want to avoid becoming a detailed repository of application descriptions: that information can be found at the `homepage` URL.
rolandwalker
added a commit
that referenced
this pull request
Jun 28, 2014
DSL: add `license` stanza
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #4688.
For forward-compatibility; intentionally left undocumented.
The
licensestanza is not free-form. There is a limitedset of valid symbols, of which the argument must be a member.
(The set will later be documented, and probably needs amendments.)
Version numbers and variants of licenses are intentionally
ommitted. The use-case for
licenseis filtering and listingof Casks. We want to avoid becoming a detailed repository of
application descriptions: that information can be found at the
homepageURL.