Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise gpg stanza order and parameters #5975

Merged
merged 1 commit into from
Sep 8, 2014

Conversation

rolandwalker
Copy link
Contributor

New syntax example:

gpg <signature-url>, :key_id => <id>

References: #5971

@ndr-qef this is only a draft for comment, but all tests have been updated as well. Note that exactly one of :key_id or :key_url is required; perhaps you don't want that.

@tapeinosyne
Copy link
Contributor

Looks good to me. One and only one key type is fine.

@tapeinosyne tapeinosyne mentioned this pull request Sep 1, 2014
9 tasks
@rolandwalker
Copy link
Contributor Author

Good. Then I'm going to merge this, and encode the updated syntax in DSL 1.0.

The fact that the code for the old syntax was published for several weeks won't matter in practice (should not inconvenience users) because it was undocumented and unused, and the feature has not yet landed.

rolandwalker added a commit that referenced this pull request Sep 8, 2014
Revise gpg stanza order and parameters
@rolandwalker rolandwalker merged commit fea75ed into Homebrew:master Sep 8, 2014
@fanquake
Copy link
Contributor

fanquake commented Sep 8, 2014

👍

@rolandwalker rolandwalker deleted the gpg_dsl_revise branch September 8, 2014 13:45
@rolandwalker rolandwalker mentioned this pull request Sep 11, 2014
9 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants