Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Standard ML New Jersey, version 110.77 #6354

Merged
merged 1 commit into from
Sep 28, 2014
Merged

Add Standard ML New Jersey, version 110.77 #6354

merged 1 commit into from
Sep 28, 2014

Conversation

tapeinosyne
Copy link
Contributor

Perhaps we should use the full name for this cask. Opinions, @vitorgalvao?

@vitorgalvao
Copy link
Member

They seem to use smlnj consistently (even on the logo), so it does seems like it’d be a recognisable name as well. I’m in no way opposed to using the full name, though; it’s one those cases where I think we should use whatever the users of it would find best. Do you use it?

@tapeinosyne
Copy link
Contributor Author

The shorthand is definitely recognizable by those who may wish to install it; additionally, it is the same name used by Homebrew.

@rolandwalker
Copy link
Contributor

The tags stanza will be live in a few days. Whichever way you decide, you can put the alternate name in

tags :name => '<alternate-name>'

Though we still have to change brew cask search to search that tag.

@tapeinosyne
Copy link
Contributor Author

Merging this as smlnj, primarily on the ground of consistency with Homebrew.

tapeinosyne pushed a commit that referenced this pull request Sep 28, 2014
Add Standard ML New Jersey, version 110.77
@tapeinosyne tapeinosyne merged commit 752fdc1 into Homebrew:master Sep 28, 2014
@tapeinosyne tapeinosyne deleted the smlnj branch February 18, 2015 16:45
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants