-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs and create
template for new license stanza
#6426
Conversation
Some of these are a bit weird, since they’re not licenses. Something can be freemium and open-source at the same time, for example. The definitions of freemium and trial also blend a bit, there. I’m also opposed to the inclusion of trial. It would (naturally) encourage the inclusion of trial software that cannot be upgraded once downloaded with homebrew-cask (such as MAS-only apps). We’ve always refused such apps, and with good reason: it’s a bad experience to download something with limitations you won’t be able to remove without extra work. |
I agree that it is harder to classify commercial and closed-source software, because commercial licenses have not become so standardized as OSS licenses. And yes, a hierarchy can never be perfect. But as to the above example case, everything under The code to support this has been out for a very long time, and I really don't want to get hung up on this now. I've already started pushing For the moment, could we just change this PR de-document most of the |
Sure. I don’t oppose the inclusion of |
some :closed licenses in the code are left undocumented for now, and should not be used.
3db8d21
to
f1604e4
Compare
@ndr-qef also expressed similar misgivings on IRC earlier, so I pared it back to So, the removed values will not be part of DSL 1.0. We should revisit later. The relevant code is flagged but not deleted. |
Yes, I am not overly fond of including |
docs and `create` template for new license stanza
Agreed. It’s a fault that I sometimes can get caught up in minutia. Apologies on that; you’re absolutely right that landing this was the important part right now, and we can deal with such intricacies later. |
@vitorgalvao, not a fault — your focus on interface boils down to wanting Cask authors to be able to get submissions right on the first try. That is essential to the project momentum, and requires forethought. |
This is the first new stanza to be added to the default template in a long time.
At the end of transition, it will become a required stanza. However, it is perfectly
fine to leave the value as
:unknown
, and we should encourage Cask authors todo so if there is any difficulty.
Likewise, we have no intention of covering the infinite possible commercial /
closed-source licenses. If there is no matching license, rather than quibble over
details, the Cask should use
license :commercial
orlicense :closed
.