Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for link artifact #7065

Merged
merged 2 commits into from
Oct 30, 2014

Conversation

rolandwalker
Copy link
Contributor

  • app, suite, and artifact no longer implemented as
    synonyms for link
  • backward-compatible code/comments removed
  • creates class Cask::Artifact::Suite
  • updates brew cask info to show specific artifact type
  • fixes stray "Generic artifact" messages
  • recasts tests to refer to "app" instead of "link"

and "activate" instead of "link" as a verb, in messages,
test names, comments, variable names.

No functional change.
* `app`, `suite`, and `artifact no longer implemented as
  synonyms for `link`
* backward-compatible code/comments removed
* creates class `Cask::Artifact::Suite`
* updates `brew cask info` to show specific artifact type
* fixes stray "Generic artifact" messages
@rolandwalker rolandwalker added the core Issue with Homebrew itself rather than with a specific cask. label Oct 29, 2014
@tapeinosyne
Copy link
Contributor

Looks good.

rolandwalker added a commit that referenced this pull request Oct 30, 2014
@rolandwalker rolandwalker merged commit 1bbf387 into Homebrew:master Oct 30, 2014
@rolandwalker rolandwalker deleted the remove_link_stanza branch October 30, 2014 13:07
@rolandwalker rolandwalker mentioned this pull request Nov 21, 2014
@rolandwalker rolandwalker mentioned this pull request Nov 29, 2014
@miccal miccal removed the core Issue with Homebrew itself rather than with a specific cask. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants