remove old-style header line from test Casks #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes the form of a horrible hack: DSL version numbers may end with "test", *eg* ":v1test". Such Casks are mapped to class `TestCask` instead of class `Cask`. The intention is that all of this logic will be removed when Casks are migrated away from separate classes. Tests driven by RSpec are still todo.
rolandwalker
added
the
core
rolandwalker
added a commit
that referenced
this pull request
Nov 19, 2014
remove old-style header line from test Casks
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the form of a horrible hack: DSL version numbers may end with "test", eg ":v1test". Such Casks are mapped to class
TestCaskinstead of classCask.The intention is that all of this logic will be removed when Casks are migrated away from separate classes.
Tests driven by RSpec are still todo. Since those tests don't read from a separate Cask file, they don't block removal of the legacy form on loads.