Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce a valid minimum DSL version in headers #7530

Merged
merged 1 commit into from
Nov 23, 2014
Merged

enforce a valid minimum DSL version in headers #7530

merged 1 commit into from
Nov 23, 2014

Conversation

rolandwalker
Copy link
Contributor

currently, "1" aka "1.0"

@rolandwalker rolandwalker added the core Issue with Homebrew itself rather than with a specific cask. label Nov 22, 2014
@rolandwalker rolandwalker mentioned this pull request Nov 22, 2014
Closed
@tapeinosyne
Copy link
Contributor

Minor: the version comparison would only work with decimal-like versions, e.g. :v1_10 > :v1_2 would be casted to 1.10 < 1.2.

@rolandwalker
Copy link
Contributor Author

Yes that part is basically wrong. One reason I didn't compare Gem::Version objects was that I had just removed require 'rubygems' in pending #7529, and I wasn't sure if these PRs would interfere with each other. We can just hold this until #7529 and fix that.

@rolandwalker rolandwalker changed the title enforce a valid minimum DSL version in headers WIP enforce a valid minimum DSL version in headers Nov 22, 2014
@rolandwalker rolandwalker force-pushed the enforce_min_dsl_version branch from 1b3fb1a to e2a0214 Compare November 23, 2014 01:08
@rolandwalker rolandwalker changed the title WIP enforce a valid minimum DSL version in headers enforce a valid minimum DSL version in headers Nov 23, 2014
tapeinosyne pushed a commit that referenced this pull request Nov 23, 2014
Merge pull request #7530 from rolandwalker/enforce_min_dsl_version
62c1ce5 
enforce a valid minimum DSL version in headers
@tapeinosyne tapeinosyne merged commit 62c1ce5 into Homebrew:master Nov 23, 2014
@claui claui mentioned this pull request Dec 2, 2014
Merged
@rolandwalker rolandwalker deleted the enforce_min_dsl_version branch December 2, 2014 16:43
@jawshooah jawshooah mentioned this pull request Sep 5, 2015
Closed
@miccal miccal removed the core Issue with Homebrew itself rather than with a specific cask. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolandwalker @tapeinosyne @miccal