Review and revise accessibility methods in postflight mini-DSL #7684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
changed the title
rolandwalker
added
the
core
* rename `remove_accessibility_access` to `disable_accessibility_access` to match corresponding method `enable_accessibility_access` * move `TCC.db` and `.AccessibilityAPIEnabled` paths to `Cask::Locations` * remove unneeded backslash from `TCC.db` path * use full paths to `touch` and `sqlite3` utilities * use `@command.run` instead of `system_command` which is intended as an external interface * reverse conditional so enable/disable logic is consistent * `sudo` is needed when creating `.AccessibilityAPIEnabled` * instead of silent fail, warn that access cannot be safely disabled on Mountain Lion and earlier (it could, but might affect other apps) * quoting/whitespace
rolandwalker
force-pushed
the
accessibility_review
branch
from
a989f3f to
2ff2db4
Compare
rolandwalker
changed the title
rolandwalker
added a commit
that referenced
this pull request
Dec 2, 2014
Review and revise accessibility methods in postflight mini-DSL
|
👍 |
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove_accessibility_accesstodisable_accessibility_accessto match corresponding methodenable_accessibility_accessTCC.dband.AccessibilityAPIEnabledpaths toCask::LocationsTCC.dbpathtouchandsqlite3utilitiessudois needed when creating.AccessibilityAPIEnabledTodo: the relevant methods are only available in either
postflightorpreflight, but they should be in both.Edit:
@command.runinstead ofsystem_commandwhich is intended as an external interfacecc @federicobond