Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cactus.app version 1.1.6 #7802

Merged
merged 1 commit into from
Dec 4, 2014
Merged

Add Cactus.app version 1.1.6 #7802

merged 1 commit into from
Dec 4, 2014

Conversation

vinkla
Copy link
Contributor

@vinkla vinkla commented Dec 4, 2014

A fast, easy and free static site generator. http://cactusformac.com/

version '1.1.6'
sha256 '14576351ee27fa6106cface713ef40677fd31d8f681c29448d8ca336bbfecd29'

url "http://cactus-trial.s3-website-us-east-1.amazonaws.com/static/downloads/Cactus%20Trial-#{version}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are you getting the url from? I’m getting http://update.cactusformac.com/static/downloads/Cactus-1.1.15.zip, on the site.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetched it with Charles. I was confused myself at first but then it worked so I used that one instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetching with Charles is a good solution in very specific cases, where a good url to get with curl is hard to find. In all other cases, we should use the canonical source presented on the website. This is not only so users are sure to get with homebrew-cask the same version they would get downloading from the site, it’s also a way for them to audit casks.

Take this as an example. I’ve merged a lot of PRs from you and know you’re a trustworthy contributor, but other users will not. When they see the url for a (now) open-source app that has “Trial” as part of it and is hosted outside the official website’s domain, it will look suspicious, and with reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. I want it to be correct and I totally agree with you. I've updated to the URL you specified and pushed an update.

vitorgalvao added a commit that referenced this pull request Dec 4, 2014
Add Cactus.app version 1.1.6
@vitorgalvao vitorgalvao merged commit 7259ab2 into Homebrew:master Dec 4, 2014
@vinkla vinkla deleted the cactus branch December 5, 2014 07:22
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants