Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cask WineBottler 1.7.25 #7814

Closed
wants to merge 1 commit into from
Closed

Conversation

hanxue
Copy link
Contributor

@hanxue hanxue commented Dec 5, 2014

No description provided.

@vitorgalvao
Copy link
Member

This cask has been discussed before. It was decided it shouldn’t be included, in part due to technical reasons. This PR somewhat solves those, but also gives a URL that is not official. Therefore I feel it does not fit, and should still be kept out.

Leaving this open in the meantime, in case other contributors want to chime in.

@vitorgalvao vitorgalvao added the awaiting maintainer feedback Issue needs response from a maintainer. label Dec 5, 2014
@rolandwalker
Copy link
Contributor

Agreed about the Cask. (Hi @hanxue !)

While we can likely improve/generalize the doc, since #6570 (and #6747) we have not been allowing urls that don't match the vendor homepage domain, unless we can verify that the exact URL is linked on the homepage.

vitorgalvao referenced this pull request Dec 14, 2014
@vitorgalvao vitorgalvao removed the awaiting maintainer feedback Issue needs response from a maintainer. label Dec 14, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants