DSL: add accessibility_access
stanza
#7854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stanza replaces the never-documented
postflight
methodsenable_accessibility_access
/disable_accessibility_access
(remove_accessibility_access
), and will also replacecaveats
/assistive_devices
which is still present in the code for the moment.The issue with the
postflight
approach is that thepostflight
blocks are opaque. We can't do anything very smart with the contents. In this case, that meant that Cask authors would need to build up and tear down accessibility permissions in each Cask:This PR replaces the procedural logic above with a declaration:
Also:
assistive_devices
staged_test.rb
for testing staged CasksNeeded future work:
accessibility_access
should accept a bundle ID value for those cases where it cannot be deduced. Currently only the firstapp
stanza is followed.accessibility_access
can't be granted in Casks without anapp
stanza.@federicobond I might have introduced the newlines into bundle identifiers in #6329