Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptol: Add cvc4 Cask dependency #8565

Merged
merged 1 commit into from
Jan 3, 2015
Merged

cryptol: Add cvc4 Cask dependency #8565

merged 1 commit into from
Jan 3, 2015

Conversation

jawshooah
Copy link
Contributor

Left the caveats alone, since it's still important that the CVC4 binary is in your PATH (installed to /opt/local/bin by default).

Per discussion in #8492.

@tapeinosyne tapeinosyne self-assigned this Dec 31, 2014
@jawshooah jawshooah changed the title Add cvc4 dependency to cryptol cryptol: Add cvc4 Cask dependency Dec 31, 2014
@vitorgalvao
Copy link
Member

Actually, we likely can remove most of the caveat, just not the files_in_usr_local part. The warning it outputs should be clear enough, and the other line of the caveat is rendered useless via your depends_on.

@jawshooah
Copy link
Contributor Author

Unfortunately not; the cvc4 binary is installed to /opt/local/bin, which is not in the PATH by default, so the warning still applies.

@tapeinosyne tapeinosyne changed the title cryptol: Add cvc4 Cask dependency HOLD cryptol: Add cvc4 Cask dependency Jan 2, 2015
@tapeinosyne
Copy link
Contributor

Note that we must wait for the next stable release, which will ship depends_on :cask, before removing caveats re dependencies.

This PR only adds the stanza (which is backward-compatible), but I would prefer not to merge multiple patches to the effect of depends_on :cask.

@rolandwalker
Copy link
Contributor

The caveats should still be removed here. Configuration of CVC4 belongs in the cvc4 Cask, and is being added in #8591.

@tapeinosyne tapeinosyne changed the title HOLD cryptol: Add cvc4 Cask dependency cryptol: Add cvc4 Cask dependency Jan 3, 2015
tapeinosyne pushed a commit that referenced this pull request Jan 3, 2015
@tapeinosyne tapeinosyne merged commit 73f359b into Homebrew:master Jan 3, 2015
@tapeinosyne
Copy link
Contributor

Cask dependencies are now available in the stable release. Merging; caveats to be removed in another PR.

@jawshooah jawshooah deleted the cryptol/add-cvc4-dep branch January 25, 2015 18:00
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants