Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgis: Add gdal-framework, matplotlib Cask dependencies #8566

Merged
merged 1 commit into from
Jan 2, 2015
Merged

qgis: Add gdal-framework, matplotlib Cask dependencies #8566

merged 1 commit into from
Jan 2, 2015

Conversation

jawshooah
Copy link
Contributor

Per discussion in #8492.

@jawshooah jawshooah changed the title Add cask dependencies for qgis qgis: Add gdal-framework, matplotlib Cask dependencies Dec 31, 2014
vitorgalvao added a commit that referenced this pull request Jan 2, 2015
qgis: Add gdal-framework, matplotlib Cask dependencies
@vitorgalvao vitorgalvao merged commit 03a2f73 into Homebrew:master Jan 2, 2015
@tapeinosyne
Copy link
Contributor

Sorry, I need to revert this. We cannot remove the caveat until depends_on :cask functionality is available in the stable release.

@jawshooah, your work is appreciated. I had mistakenly assumed that we would not receive external contributions during New Year, and failed to advertise that depends_on :cask stanzas would need to be held until release.

@jawshooah
Copy link
Contributor Author

Ah, my apologies. I figured that these changes would be included in the first stable release to feature the new functionality.

@tapeinosyne
Copy link
Contributor

Unfortunately that is not the case, which can be confusing: Casks (i.e. the definition files) are updated independently of the actual brew cask command functionality.

@vitorgalvao
Copy link
Member

Apologies for my haste in merging these, @ndr-qef; it didn’t cross my mind to check if the changes were already deployed. Shouldn’t sshfs.rb be reverted as well?

@tapeinosyne
Copy link
Contributor

Not to worry; I was largely absent after #8491 and neglected to provide adequate explanation of the follow-ups.

The patch to sshfs needs not be reverted: depends_on :cask has been present in the DSL for quite a while. However, because the stanza will be inoperative until the next release, caveats must include instructions to manually install dependencies.

@jawshooah jawshooah deleted the qgis/add-cask-deps branch January 25, 2015 18:00
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants